Escape test/suite title for re in html reporter

[benvinegar]

Fixes #1687

[dasilvacontin]

Hi @benvinegar! Could you provide tests that assert this change fixes the issue? Thanks!

[benvinegar]

@dasilvacontin Where do you recommend adding that? I could introduce a new /reporter test for the Html reporter (there isn't one yet), and verify that makeUrl escapes the grep component.

[benvinegar]

Or I could add a new test to test/browser/, similar to test/browser/grep.html, which clicks through generated grep links to verify they work (instead of manipulating window.location directly).

[jbnicolai]

@benvinegar sorry for the silence on our side. Great fix! I'd recommend the later (simply because it seems easier), but both would prove the fix so pick whichever you'd prefer.

[benvinegar]

Okay. I've added a test that demonstrates that clicking through links w/ regex chars works correctly.

But, I'm not sure how to run this test as part of CI. I'm not sure if test/browser/grep.* runs as part of CI either.

Please advise.

[boneskull]

But, I'm not sure how to run this test as part of CI. I'm not sure if test/browser/grep.* runs as part of CI either.

test/browser is omitted from CI. I don't have much experience with them, but looking over them briefly I don't think they have much value in the first place--especially since the only way you can assert they work is to eyeball them.

[boneskull]

@benvinegar thanks again!