Skip to content

Fix % always 0 in HTML reporter #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boneskull merged 2 commits into from
Jun 26, 2016
Merged

Fix % always 0 in HTML reporter #2299

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
966ab86
Fix % always 0 in HTML reporter
Jun 8, 2016
85ffb51
Alternative method to achieve a cleaner syntax.
Jun 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix % always 0 in HTML reporter 
updateStats() accesses this.total, but this === the global object (window) if not specified explicitly.
Also added a missing update when all tests end.
  • Loading branch information
Avi Vahl committed Jun 8, 2016
commit 966ab86017d469332e62aa501d1c8776ed47ef9d
7 changes: 4 additions & 3 deletions lib/reporters/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ function HTML(runner) {

runner.on('suite end', function(suite) {
if (suite.root) {
updateStats.call(this);
Copy link
Member

@boneskull boneskull Jun 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just use Function.prototype.bind() on updateStats instead?

return;
}
stack.shift();
Expand All @@ -137,7 +138,7 @@ function HTML(runner) {
var el = fragment(markup, test.speed, test.title, test.duration, url);
self.addCodeToggle(el, test.body);
appendToStack(el);
updateStats();
updateStats.call(this);
});

runner.on('fail', function(test) {
Expand Down Expand Up @@ -177,13 +178,13 @@ function HTML(runner) {

self.addCodeToggle(el, test.body);
appendToStack(el);
updateStats();
updateStats.call(this);
});

runner.on('pending', function(test) {
var el = fragment('<li class="test pass pending"><h2>%e</h2></li>', test.title);
appendToStack(el);
updateStats();
updateStats.call(this);
});

function appendToStack(el) {
Expand Down