Skip to content

Exit process with correct error codes #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boneskull merged 2 commits into from
Sep 18, 2016
Merged

Exit process with correct error codes #2445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7148a7f
Exit with code 130 in SIGINT. Refs #2438
Munter Aug 15, 2016
758f412
Exit with code 255 if more errors than 255 were returned. Fixes #2438
Munter Aug 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions bin/_mocha
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ if (program.watch) {
process.on('SIGINT', function() {
showCursor();
console.log('\n');
process.exit();
process.exit(130);
});

var watchFiles = utils.files(cwd, [ 'js' ].concat(program.watchExtensions));
Expand Down Expand Up @@ -442,7 +442,7 @@ if (program.watch) {

function exitLater(code) {
process.on('exit', function() {
process.exit(code);
process.exit(Math.min(code, 255));
});
}

Expand All @@ -452,7 +452,7 @@ function exit(code) {
// https://github.com/visionmedia/mocha/issues/333 has a good discussion
function done() {
if (!(draining--)) {
process.exit(code);
process.exit(Math.min(code, 255));
}
}

Expand All @@ -470,6 +470,11 @@ function exit(code) {

process.on('SIGINT', function() {
runner.abort();

// This is a hack:
// Instead of `process.exit(130)`, set runner.failures to 130 (exit code for SIGINT)
// The amount of failures will be emitted as error code later
runner.failures = 130;
});

/**
Expand Down