options.reporterOptions are used for progress reporter
#3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress reporter had multiple options for configuring the reporter, but it needed the optional fields under `options` object, while those fields are provided under `options.reporterOptions`. This commit enables usage of optional fields from `reporterOptions`. Updated test cases as well.
boneskull
added
the
semver-patch
Member
|
@canoztokmak LGTM, thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress reporter had multiple options for configuring the reporter,
but it needed the optional fields under
optionsobject, whilethose fields are provided under
options.reporterOptions.This commit enables usage of optional fields from
reporterOptions.Updated test cases as well.
Fix for #2661