Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Drop node.js v6 support
  • Loading branch information
mojosoeun committed Apr 20, 2019
commit 56a040e47ac435e83c0b4271ee4ccebd82211ddb
3 changes: 0 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ jobs:
- <<: *node
node_js: '8'

- <<: *node
node_js: '6'

- script: npm start test.bundle test.browser
install: npm ci # we need the native modules here
addons:
Expand Down
1 change: 0 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ environment:
- nodejs_version: '11'
- nodejs_version: '10'
- nodejs_version: '8'
- nodejs_version: '6'
matrix:
fast_finish: true
install:
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ _So you wanna build the site?_

## Prerequisites

- Node.js v6.x or greater
- Node.js v8.x or greater

## Development

Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ or as a development dependency for your project:
$ npm install --save-dev mocha
```

> As of v6.0.0, Mocha requires Node.js v6.0.0 or newer.
> As of v6.0.0, Mocha requires Node.js v8.0.0 or newer.
Comment thread
juergba marked this conversation as resolved.
Outdated

## Getting Started

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@
"test": "./test"
},
"engines": {
"node": ">= 6.0.0"
"node": ">= 8.0.0"
},
"scripts": {
"prepublishOnly": "nps test clean build",
Expand Down
50 changes: 0 additions & 50 deletions test/integration/options/debug.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,54 +77,4 @@ describe('--debug', function() {
);
});
});

describe('Node.js v6', function() {
// note that v6.3.0 and newer supports --inspect but still supports --debug.
before(function() {
if (process.version.substring(0, 2) !== 'v6') {
this.skip();
}
});

it('should start debugger', function(done) {
var proc = invokeMocha(
['--debug', DEFAULT_FIXTURE],
function(err, res) {
if (err) {
return done(err);
}
expect(res, 'to contain output', /Debugger listening/i);
done();
},
'pipe'
);

// debugger must be manually killed
setTimeout(function() {
process.kill(proc.pid, 'SIGINT');
}, 2000);
});

it('should respect custom host/port', function(done) {
var proc = invokeMocha(
['--debug=127.0.0.1:9229', DEFAULT_FIXTURE],
function(err, res) {
if (err) {
return done(err);
}
expect(
res,
'to contain output',
/Debugger listening on .*127.0.0.1:9229/i
);
done();
},
'pipe'
);

setTimeout(function() {
process.kill(proc.pid, 'SIGINT');
}, 2000);
});
});
});