Skip to content

tty.getWindowSize is not a function inside a "worker_threads" worker #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juergba merged 2 commits into from
Jul 20, 2019
Merged

tty.getWindowSize is not a function inside a "worker_threads" worker #3955

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6714e4
Use "isTTY" instead of tty.isatty(fd)
1999 Jun 22, 2019
b4a9938
Remove Boolean()
1999 Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/reporters/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ exports = module.exports = Base;
* Check if both stdio streams are associated with a tty.
*/

var isatty = tty.isatty(1) && tty.isatty(2);
var isatty = Boolean(process.stdout.isTTY) && Boolean(process.stderr.isTTY);

/**
* Save log references to avoid tests interfering (see GH-3604).
Expand Down