Skip to content

Soft deprecate configuration via "mocha.opts" #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juergba merged 4 commits into from
Aug 26, 2019
Merged

Soft deprecate configuration via "mocha.opts" #3968

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fce4c54
soft deprecate configuration via mocha.opts
juergba Jul 21, 2019
3dd4c71
additional test
juergba Jul 22, 2019
56e99e9
docu update
juergba Aug 1, 2019
d69b38c
adapt examples of config files
juergba Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
additional test
  • Loading branch information
@juergba
juergba committed Aug 26, 2019
commit 3dd4c711e3dc1bc88740c757a838fcd02add0d69
18 changes: 18 additions & 0 deletions test/integration/options/opts.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,24 @@ describe('--opts', function() {
var args = [];
var fixture = path.join('options', 'opts');

it('should print a deprecation warning', function(done) {
var mochaOpts = path.join('test', 'opts', 'mocha.opts');
args = [resolvePath(fixture), '--opts', mochaOpts];
invokeMocha(
args,
function(err, res) {
if (err) {
return done(err);
}

expect(res, 'to have passed');
expect(res.output, 'to contain', 'mocha.opts is DEPRECATED');
done();
},
'pipe'
);
});

it('should work despite nonexistent default options file', function(done) {
args = [];
runMochaJSON(fixture, args, function(err, res) {
Expand Down