Set minimum OTP to 18 #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
force-pushed
the
minimum-otp-18
branch
2 times, most recently
from
0d4baad to
e081ef0
Compare
Since we're not inspecting the message in handle_invalid_msg_request any longer, we don't have to pass the message in altogether.
Collaborator
|
I noticed you were way ahead of me! I just had two minor patches to fix the CI and noticed tiny bit more cleanup that can be done after the R15 |
Two minor patches to help with Erlang <18 support removal
Member
Author
|
@nickva I think the only other thing on the radar that is worth considering for a 3.0 release would be finally upgrading to rebar3, since we are breaking some compatibility anyway. What do you think about that? Is that something you'd be interested in helping with? |
Collaborator
|
@etrepum that make sense, I can give it a try. We had tried it for CouchDB but that one has so many nifs, raw resources and other odd things that it stalled a bit apache/couchdb#3938 but MochiWeb should be quite a bit simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.