[MOOSE-156] Consolidade navigation block styles #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the navigation system's styling architecture to use a centralized coordinator pattern, consolidating all first-level navigation styles and toggle button styles into the
navigation-wrapperblock. Individual navigation blocks now only handle their own content-specific styles, which reduces code duplication and makes maintenance easier. Documentation has been updated to reflect the new architecture, and redundant or duplicated CSS has been removed from individual block styles.Note
Architecture Decision Point: This PR consolidates all shared navigation styles into the Navigation Wrapper block since it acts as the parent container for all navigation types. I'd like the team's input on whether this centralized approach is optimal, or if these shared styles should be moved to global theme styles. The current approach keeps navigation-specific styles within the navigation block system, but I'm open to feedback on the best architectural pattern for shared component styling.
CSS Refactoring: Centralized Styles
navigation-wrapper/style.pcss, making it the single source of truth for navigation styling. Utility and primary menu overrides are also handled here.Block-Specific CSS Simplification
mega-menu-item/style.pcssandstandard-menu-item/style.pcss, leaving only dropdown container, layout, and submenu wrapper styles in those files.navigation-link/style.pcssto provide only base link styling (underline, transitions, focus states), with context-specific enhancements now handled by the Navigation Wrapper.Editor CSS Adjustments
standard-menu-item/editor.pcssfor improved editor preview consistency.Navigation System Architecture & Documentation
docs/navigation-blocks.mdto describe a centralized styling coordinator pattern, whereNavigation Wrappermanages all first-level navigation and toggle button styles, and individual blocks (Mega Menu Item, Standard Menu Item, Navigation Link) handle only content-specific styling. This includes new sections on CSS architecture, file organization, and development guidelines.Overall, these changes make navigation styling more maintainable, consistent, and easier to update, with a clear separation of responsibilities between the centralized coordinator and individual content blocks.
QA
Links to relevant issues