-
Notifications
You must be signed in to change notification settings - Fork 5
Color picker field #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Color picker field #272
Conversation
GeoffDusome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to want a FE dev to go through this when you're ready to clean up the JS & CSS, but this is a good start to a swatch picker. Let me know when it's done and I'll take another look!
wp-content/plugins/core/src/Integrations/ACF_Fields/Color_Picker/Color_Picker.php
Outdated
Show resolved
Hide resolved
wp-content/plugins/core/src/Integrations/Integrations_Subscriber.php
Outdated
Show resolved
Hide resolved
GeoffDusome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Just one note from me - looks good otherwise. It's insane to me that you were able to utilize my Dynamic Color Picker to render ACF options but here we are. Amazing work 🌮
Co-authored-by: Geoff Dusome <[email protected]>
What does this do/fix?
Introduce a new custom ACF field type Color Picker (
color_picker_tribe) to the plugin.This adds:
What’s included
wp-content/plugins/core/src/Integrations/ACF_Fields/Color_Picker/Color_Picker.php- defines the ACF field type, with fluent colors() setter and default palette extraction.wp-content/plugins/core/src/Integrations/ACF_Fields/Color_Picker/Color_Picker_Render.php- the rendering logic for the field in the admin (shows swatches, builds hidden input).wp-content/themes/core/assets/js/editor/color-picker/index.js- add wrapper forDynamicColorPickerand pass data from ACF to Gutenberg componentQA
Links to relevant issues
Screenshots/video: