[MOOSE-308] Terms Block Edits #285
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
This PR fixes an issue @Vinsanity was having with Mediavine where a CPT existed with only one taxonomy assigned. This caused the
onChangefunction of theSelectControlto never be able to be called, which meant the value was never correct for the block on this post type.To fix, I've done the following:
defaultvalue from thetaxonomyToUseattribute on the block to an empty string.SelectControlfortaxonomyToUseto use adisabledoption as it's default state. This means, unless set in a pattern or template, the block will always default to "no taxonomy selected".edit.jsfile to usewithSelect, as this is the intended way to grab information from the select API prior to rendering blocks.post.phpandpost-left-aligned.phppatterns to specifically choose thecategorytaxonomy as the default for those usages of the block (otherwise no taxonomy would be chosen when creating new posts).Additionally:
QA
Links to relevant issues
Screenshots/video: