Skip to content

Conversation

@GeoffDusome
Copy link
Contributor

@GeoffDusome GeoffDusome commented Dec 30, 2025

What does this do/fix?

This pull request cleans up and improves the core Details block in both style and configuration, focusing on code clarity, consistent styling, and better maintainability. The main changes include reorganizing and commenting the styles, updating underline behavior for summaries, and reordering the theme.json styles for clarity.

Core Details Block Cleanup and Styling Improvements:

  • Added comments and reordered sections in style.pcss to clarify the purpose of style rules, and applied consistent underline styling to the summary element using mixins for both normal and hover states. [1] [2]

Configuration and Maintainability:

  • Reordered the typography, spacing, and border properties for the core/details block in theme.json to improve clarity and maintainability, without changing the actual styles applied. [1] [2]
  • Updated the changelog to reflect the cleanup and improvements made to the core Details block.

QA

Links to relevant issues

Screenshots/video:

@GeoffDusome GeoffDusome added the Launch Environment Deploys to dokku label Dec 31, 2025
Copy link
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@GeoffDusome GeoffDusome added In QA Waiting on QA and removed Needs FE Review labels Jan 5, 2026
@GeoffDusome GeoffDusome merged commit 9e3cb87 into main Jan 9, 2026
7 checks passed
@GeoffDusome GeoffDusome deleted the task/MOOSE-292/details-block branch January 9, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In QA Waiting on QA Launch Environment Deploys to dokku

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants