[MOOSE-301] Decorative Headings Use <div> Instead of <span>
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffDusome
requested review from
LayaTaal,
Vinsanity,
dpellenwood,
spadilha and
tylermachado
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
This pull request updates the decorative heading feature in the core heading block to use
<div>tags instead of<span>tags for accessibility purposes. The main changes involve renaming the relevant attribute and updating both the PHP and JS logic to reflect the switch from<span>to<div>.Decorative Heading Tag Update:
useSpanTagtouseDivTagin both the PHP (Heading.php) and JS (editor.js) implementations.Heading.phpto replace heading tags with<div>tags instead of<span>, and renamed the function accordingly. [1] [2] [3]Editor UI and Help Text:
<div>tags for decorative headings, including updated help text for clarity.QA
Links to relevant issues