[MOOSE-325] Masthead Search Icon #300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
This pull request improves the way the search icon SVG is loaded in the
masthead-searchblock to make it more robust and reliable. Instead of directly fetching the SVG using a URL, it first tries to read the file from the file system and falls back to a remote request only if necessary. This is a similar approach we took while grabbing thetheme.jsonfile in the Block Editor Custom Alignments plugin.Improvements to SVG loading:
file_get_contentsand only falls back to usingwp_remote_getif the file read fails, ensuring better reliability and compatibility across environments.QA
Links to relevant issues
Screenshots/video: