Updated random_math functionality #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 9, 2020 19:08
… of repeating chars - Verification of empty sourcechars and 0 length random text. - Implement logic to generate randomText in better way
1. Updated randIntRange Issue so that it doesn't panic for negative numbers 2. Updated test cases for generating randomcolor and random id
Author
|
Good to go inside? |
Collaborator
|
hi, @mojocn @JJJJJJJerk Would you mind to take this PR a review? I think it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
random_math.goandrandom_math_test.gofiles.random(min, max int) float64did not return value between the range.Updated code and added test cases.