Skip to content

feat(compass-collection): gate experiment feature behind redux state check instead of hook call - CLOUDP-344022 #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jcobis wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat(compass-collection): gate experiment feature behind redux state check instead of hook call - CLOUDP-344022 #7298

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eda194e
WIP
jcobis Sep 9, 2025
c23b7d7
Consolidate helper functions in test file
jcobis Sep 9, 2025
f7a0f35
Remove useAssignment hook
jcobis Sep 9, 2025
6548018
typo
jcobis Sep 9, 2025
b1daccc
Change action to not dispatch error for empty collection
jcobis Sep 9, 2025
ebe4412
Make test method constant
jcobis Sep 9, 2025
47f2247
Restore useAssignment hook
jcobis Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make test method constant
  • Loading branch information
@jcobis
jcobis committed Sep 9, 2025
commit ebe4412d4f3ba681593ad31b9184fd9e7e5144b7
6 changes: 1 addition & 5 deletions packages/compass-collection/src/components/collection-header/collection-header.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ function renderCollectionHeader(

const mockStore = createStore(() => defaultState);

const renderMethod = connectionInfo
? renderWithActiveConnection
: renderWithConnections;

return renderMethod(
return renderWithActiveConnection(
<Provider store={mockStore}>
<WorkspacesServiceProvider value={workspaceService as WorkspacesService}>
<CollectionHeader
Expand Down
Loading