chore(data-modeling): memoize functions passed to diagramming #7349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good practice in general to help reduce unnecessary re-rendering.
It's also mentioned in react flow's docs: https://reactflow.dev/learn/advanced-use/performance#memoize-functions
We already do this in the diagramming package: https://github.com/mongodb-js/diagramming/blob/e5edc84fcc4fb6c960333c690cf0e291cd75c6c3/src/components/canvas/canvas.tsx#L146