Skip to content

feat(data-modeling): allow inline field type changes COMPASS-9799 #7514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mabaasit merged 6 commits into from
Dec 15, 2025
Merged

feat(data-modeling): allow inline field type changes COMPASS-9799 #7514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83e7177
dump lg select and fix tests
mabaasit Oct 29, 2025
3e6cfaa
integrate with local version
mabaasit Oct 29, 2025
b3ddf53
Merge branch 'main' of https://github.com/mongodb-js/compass into COM…
mabaasit Dec 11, 2025
56d6196
bootstrap
mabaasit Dec 11, 2025
39bc533
undo irrelevant changes
mabaasit Dec 11, 2025
a7e3113
pr feedback
mabaasit Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pr feedback
  • Loading branch information
@mabaasit
mabaasit committed Dec 12, 2025
commit a7e31131612f19db0e3d7beb3a5d19b339a144cf
5 changes: 4 additions & 1 deletion packages/compass-data-modeling/src/components/drawer/field-drawer-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useMemo, useState } from 'react';
import React, { useEffect, useMemo, useState } from 'react';
import { connect } from 'react-redux';
import type {
FieldPath,
Expand Down Expand Up @@ -131,6 +131,9 @@ const FieldDrawerContent: React.FunctionComponent<FieldDrawerContentProps> = ({
string | undefined
>();
const [fieldTypes, setFieldTypes] = useState<string[]>(types);
useEffect(() => {
setFieldTypes(types);
}, [types]);

const { value: fieldName, ...nameInputProps } = useChangeOnBlur(
fieldPath[fieldPath.length - 1],
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-data-modeling/src/store/diagram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,8 +864,8 @@ export function changeFieldType({
jsonSchema: collectionSchema,
fieldPath: fieldPath,
});
const oldTypes = field?.fieldTypes;
if (!field) throw new Error('Field not found in schema');
const oldTypes = field.fieldTypes;
const to = getSchemaWithNewTypes(field.jsonSchema, newTypes);

track('Data Modeling Field Type Changed', {
Expand Down
Loading