Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
85e5dcf
pass release notes to publish action, and make it idempotent
jamis Jun 6, 2025
3e526e9
split build & publish
jamis Jun 9, 2025
84b5369
add PR-check action
jamis Jun 12, 2025
040fd64
add some debugging for troubleshooting
jamis Jun 13, 2025
fde9f93
more debugging
jamis Jun 13, 2025
d0e0dec
typo
jamis Jun 13, 2025
066352c
add `ref` input parameter
jamis Jun 16, 2025
057146a
permit write access to publish as well
jamis Jun 16, 2025
023a472
troubleshooting: show the permissions of the current user
jamis Jun 16, 2025
73e3905
fix indentation
jamis Jun 16, 2025
bdbbe4d
use role_name instead of permissions
jamis Jun 16, 2025
96dfd86
wrong quotes
jamis Jun 16, 2025
fb201ad
checkout submodules -- so the candidate.rake tasks can load
jamis Jun 16, 2025
ff75009
can't use pattern with merge-multiple
jamis Jun 16, 2025
1eb56ea
use `cat`, not `echo`, when writing a heredoc to a file
jamis Jun 16, 2025
3178251
build using a rake task, to accommodate gems that need a compile step
jamis Jun 17, 2025
2752ec6
pr-check action only works with push & workflow_dispatch
jamis Jun 19, 2025
f89b3ee
some debugging output to help troubleshooting
jamis Jun 19, 2025
cccd2b1
a bit more debug output
jamis Jun 19, 2025
d35fd27
okay, possibly checking the right things now
jamis Jun 19, 2025
5e58425
try again
jamis Jun 19, 2025
85472de
fix syntax error
jamis Jun 19, 2025
7c3926f
more debugging
jamis Jun 19, 2025
10239c3
need to get the actual PR record once we know its number
jamis Jun 19, 2025
339da5f
pulls/get doesn't return a list
jamis Jun 19, 2025
7c38a00
it's not a list, but it's still wrapped
jamis Jun 19, 2025
6da6fb7
remove debugging output
jamis Jun 19, 2025
e74b084
Merge branch 'main' into ruby-3643-update-release-process
jamis Jul 24, 2025
3eece64
remove trailing whitespace
jamis Jul 24, 2025
e8adfe6
pin to specific commit
jamis Jul 24, 2025
2947587
pin all action references
jamis Jul 24, 2025
83826e7
avoid potential template injection exploits
jamis Jul 24, 2025
d681705
trailing whitespace
jamis Jul 24, 2025
a385189
Add a comment to explain the obscure identifier
jamis Jul 28, 2025
e384925
document each commit SHA
jamis Jul 28, 2025
8fd60d1
Merge branch 'main' into ruby-3643-update-release-process
jamis Aug 20, 2025
7c367f3
allow variable interpolation in the heredoc
jamis Aug 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
need to get the actual PR record once we know its number
  • Loading branch information
jamis committed Jun 19, 2025
commit 10239c3069bd1945f49eb41ea2d323cd45b0cdef
16 changes: 13 additions & 3 deletions ruby/pr-check/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,27 @@ runs:
// because only maintainers can push to protected branches,
// we can assume the user has the correct permissions to do
// this.
const { data: results } = await github.rest.repos.listPullRequestsAssociatedWithCommit({
const { data: listing } = await github.rest.repos.listPullRequestsAssociatedWithCommit({
owner: context.repo.owner,
repo: context.repo.repo,
commit_sha: context.payload.after,
});

if (results.length == 0) {
if (listing.length == 0) {
throw new Error(`Workflow aborted: No pull request found for the pushed commit (${context.payload.after}).`);
}

pr = results[0];
const { data: prs } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: listing[0].number,
});

if (prs.length == 0) {
throw new Error(`Workflow aborted: No pull request found with the requested number. (${number})`);
}

pr = prs[0];

// if it wasn't triggered by a push event, was it triggered by
// a workflow_dispatch event?
Expand Down