This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Attach 'docs' to version pathing #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casthewiz
commented
Mar 22, 2022
| {% if not v.current %} | ||
| <li> | ||
| <a href="#" data-path="{{ v.path }}" class="is-on-prem mms-version-selector"> | ||
| <a href="#" data-path="{{ 'docs/' + v.path }}" class="is-on-prem mms-version-selector"> |
Contributor
Author
There was a problem hiding this comment.
No idea if this codepath is still in use, tried to find where it existed but couldn't find a selector with class 'is-on-prem' or 'mms-version-selector' 🤷♂️
schmalliso
approved these changes
Mar 22, 2022
Contributor
schmalliso
left a comment
schmalliso
left a comment
There was a problem hiding this comment.
I'm approving since it seems like Andrew did on Slack?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed naive fix for legacy version selector.
Potentially fixes observed behavior at https://www.mongodb.com/docs/kubernetes-operator/stable/