Skip to content

[3.8] Add support for cursor pagination #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2022
Merged

[3.8] Add support for cursor pagination #2358

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16e8f91
Add support for cursor pagination
Jeroenwv Feb 23, 2022
d6652de
Fix CS issues
Jeroenwv Feb 23, 2022
464af94
Fix CS issues
Jeroenwv Feb 23, 2022
0567794
feat: improve logic
divine Mar 1, 2022
cbfaa8e
chore: update changelog
divine Mar 7, 2022
f2a9644
chore: fix changelog
divine Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CS issues 
This commit fixes CS issues
  • Loading branch information
@Jeroenwv
Jeroenwv committed Feb 23, 2022
commit d6652de1f2e8d9757f123f0aef9d3a99d04a0d6b
7 changes: 5 additions & 2 deletions src/Eloquent/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class Builder extends EloquentBuilder

/**
* The methods that should be returned from query builder.
*
* @var array
*/
protected $passthru = [
Expand Down Expand Up @@ -191,6 +192,7 @@ public function raw($expression = null)
* TODO Remove if https://github.com/laravel/framework/commit/6484744326531829341e1ff886cc9b628b20d73e
* wiil be reverted
* Issue in laravel frawework https://github.com/laravel/framework/issues/27791.
*
* @param array $values
* @return array
*/
Expand Down Expand Up @@ -235,10 +237,11 @@ protected function ensureOrderForCursorPagination($shouldReverse = false)
return $this->mapMongodbOrdersToEloquentOrders($this->query->orders);
}

private function mapMongodbOrdersToEloquentOrders($orders) {
private function mapMongodbOrdersToEloquentOrders($orders)
{
$eloquentOrders = [];

foreach($orders as $column => $direction) {
foreach ($orders as $column => $direction) {
$eloquentOrders[] = [
'column' => $column,
'direction' => $direction === 1 ? 'asc' : 'desc',
Expand Down