Skip to content

[LG-5601] fix(modal): restore conditional rendering of children when closed #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephl3 merged 3 commits into from
Oct 7, 2025
Merged

[LG-5601] fix(modal): restore conditional rendering of children when closed #3189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d697797
fix(modal): conditionally render children when open toggles
stephl3 Oct 7, 2025
263a63b
chore(modal): changeset
stephl3 Oct 7, 2025
98ad0f9
fix(modal): tests
stephl3 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(modal): tests
  • Loading branch information
@stephl3
stephl3 committed Oct 7, 2025
commit 98ad0f9a921dd7dae47a29675eccc913f72cdbb4
10 changes: 7 additions & 3 deletions packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ describe('packages/confirmation-modal', () => {
});

test('does not render if closed', () => {
const { getByText } = renderModal();
expect(getByText('Content text')).not.toBeVisible();
const { queryByText } = renderModal();
expect(queryByText('Content text')).toBeNull();
});

test('renders if open', () => {
Expand Down Expand Up @@ -329,14 +329,18 @@ describe('packages/confirmation-modal', () => {
</ConfirmationModal>,
);

const rerenderedConfirmationButton = await findByTestId(
lgIds.confirm,
);

if (requiredInputText) {
textInput = getByLabelText(
`Type "${requiredInputText}" to confirm your action`,
);
expect(textInput).toHaveValue('');
}

expect(confirmationButton).toHaveAttribute(
expect(rerenderedConfirmationButton).toHaveAttribute(
'aria-disabled',
disabledAfterReopeningModal.toString(),
);
Expand Down
4 changes: 2 additions & 2 deletions packages/marketing-modal/src/MarketingModal/MarketingModal.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ describe('packages/marketing-modal', () => {
});
});
test('does not render if closed', () => {
const { getByText } = renderModal();
expect(getByText('Content text')).not.toBeVisible();
const { queryByText } = renderModal();
expect(queryByText('Content text')).toBeNull();
});

test('renders if open', () => {
Expand Down
Loading