Skip to content

Fix AbstractWriteSearchIndexOperation executeAsync releasing connections #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rozza merged 4 commits into from
Oct 1, 2025
Merged

Fix AbstractWriteSearchIndexOperation executeAsync releasing connections #1812

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d50af41
Fix AbstractWriteSearchIndexOperation executeAsync releasing connections
rozza Sep 30, 2025
8d01554
Copilot updates
rozza Sep 30, 2025
1e2084f
Releasing of connections may not be instantanious
rozza Oct 1, 2025
9a7d3e5
Ensure errors thrown outside of the callback also release the resource
rozza Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Copilot updates
  • Loading branch information
@rozza
rozza committed Sep 30, 2025
commit 8d0155425292a8437d86f398681030a9e505c706
4 changes: 2 additions & 2 deletions ...ms/src/test/functional/com/mongodb/reactivestreams/client/AsyncTransportSettingsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void testAsyncTransportSettings() {
.transportSettings(asyncTransportSettings)
.build();

try (MongoClient client = new SyncMongoClient(mongoClientSettings);) {
try (MongoClient client = new SyncMongoClient(mongoClientSettings)) {
client.listDatabases().first();
}
verify(executorService, atLeastOnce()).execute(any());
Expand All @@ -67,7 +67,7 @@ void testExternalExecutorWasShutDown(final boolean tlsEnabled) throws Interrupte
.transportSettings(asyncTransportSettings)
.build();

try (MongoClient ignored = new SyncMongoClient(mongoClientSettings);) {
try (MongoClient ignored = new SyncMongoClient(mongoClientSettings)) {
// ignored
}

Expand Down