Rate limit new connection creations (maxConnecting) #685

stIncMale · 2021-03-16T08:02:45Z

JAVA-3927

…alization concept JAVA-3927

JAVA-3927

stIncMale · 2021-03-16T14:22:44Z

If that would be helpful, we may have a call for walking through the code at virtually any time.

driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java

…iled to open a connection JAVA-3927

driver-core/src/test/unit/com/mongodb/internal/connection/AbstractConnectionPoolTest.java

stIncMale · 2021-03-17T19:42:34Z

I will soon finish addressing the issues that we discussed over Zoom. Having them checked in will (hopefully) simplify the review process a bit.

JAVA-3927

stIncMale · 2021-03-18T01:43:54Z

I addressed the test failure on Evergreen in JAVA-4075. It is not related to the changes in this PR.

….CONNECTION_ERROR JAVA-3927

...core/src/test/unit/com/mongodb/internal/connection/DefaultConnectionPoolSpecification.groovy

…e lock uninterruptibly JAVA-3927

rozza

Its looking good. I have a couple of comments / suggestions regarding the Timeout class.

driver-core/src/main/com/mongodb/internal/Timeout.java

JAVA-3927

jyemin

This looks really good. I have a number of comments but none are major issues.

driver-core/src/main/com/mongodb/event/ConnectionPoolListener.java

driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java

JAVA-3927

driver-core/src/main/com/mongodb/MongoException.java

driver-core/src/main/com/mongodb/MongoInterruptedException.java

JAVA-3927

…nPool.checkoutHandOverMechanism JAVA-3927

JAVA-3927

jyemin

Looking great. I'm glad the new tests were useful.

Just one open thread about the use of initCause.

…tions JAVA-3927

jyemin

LGTM!

rozza

LGTM!

stIncMale force-pushed the JAVA-3927 branch from 069d141 to 15dead7 Compare March 16, 2021 08:14

stIncMale added 4 commits March 16, 2021 02:31

Refactor ConcurrentPool so that it becomes agnostic of the item initi…

b16a727

…alization concept JAVA-3927

Implement maxConnecting in DefaultConnectionPool.get

f21d299

JAVA-3927

Add specification tests

9371a8b

JAVA-3927

Implement integration style CMAP specification tests

388a7a7

JAVA-3927

stIncMale force-pushed the JAVA-3927 branch from 15dead7 to 7840fed Compare March 16, 2021 09:30

stIncMale added 2 commits March 16, 2021 03:38

Implement maxConnecting in DefaultConnectionPool.getAsync

1e75fe0

JAVA-3927

Fix static validation issues

8360c76

JAVA-3927

stIncMale force-pushed the JAVA-3927 branch from 7840fed to 8360c76 Compare March 16, 2021 09:42

Implement runOn in AbstractConnectionPoolTest

045fe13

JAVA-3927

stIncMale requested review from jyemin and rozza March 16, 2021 14:20

stIncMale commented Mar 16, 2021

View reviewed changes

driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java Outdated Show resolved Hide resolved

stIncMale commented Mar 17, 2021

View reviewed changes

driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java Outdated Show resolved Hide resolved

stIncMale force-pushed the JAVA-3927 branch 3 times, most recently from 9c0c4a5 to 4bf5802 Compare March 17, 2021 04:52

Send ConnectionCheckOutFailedEvent with Reason.CONNECTION_ERROR if fa…

5e5c7c0

…iled to open a connection JAVA-3927

stIncMale force-pushed the JAVA-3927 branch from 4bf5802 to 5e5c7c0 Compare March 17, 2021 14:25

stIncMale commented Mar 17, 2021

View reviewed changes

driver-core/src/test/unit/com/mongodb/internal/connection/AbstractConnectionPoolTest.java Show resolved Hide resolved

stIncMale force-pushed the JAVA-3927 branch 3 times, most recently from 0ae1594 to 0298746 Compare March 17, 2021 21:38

Address the first set of review concerns

459466a

JAVA-3927

stIncMale force-pushed the JAVA-3927 branch from 0298746 to 459466a Compare March 17, 2021 21:43

Add an test for DefaultConnectionPool.getAsync that checks for Reason…

4dae245

….CONNECTION_ERROR JAVA-3927

stIncMale commented Mar 18, 2021

View reviewed changes

...core/src/test/unit/com/mongodb/internal/connection/DefaultConnectionPoolSpecification.groovy Show resolved Hide resolved

stIncMale requested a review from rozza March 26, 2021 00:00

Make it clearer that releasePermit and tryHandOver methods acquire th…

f5967d1

…e lock uninterruptibly JAVA-3927

rozza reviewed Mar 26, 2021

View reviewed changes

driver-core/src/main/com/mongodb/internal/Timeout.java Outdated Show resolved Hide resolved

driver-core/src/main/com/mongodb/internal/Timeout.java Outdated Show resolved Hide resolved

driver-core/src/main/com/mongodb/internal/Timeout.java Show resolved Hide resolved

stIncMale force-pushed the JAVA-3927 branch 3 times, most recently from ab535dc to f9b6609 Compare March 26, 2021 21:29

stIncMale requested a review from rozza March 26, 2021 21:30

Replace Timeout.remainingNanos with remaining(TimeUnit)

1e29f20

JAVA-3927

stIncMale force-pushed the JAVA-3927 branch from f9b6609 to 1e29f20 Compare March 27, 2021 03:08

jyemin requested changes Mar 30, 2021

View reviewed changes

Address review concerns

d3a9195

JAVA-3927

stIncMale commented Mar 31, 2021

View reviewed changes

driver-core/src/main/com/mongodb/MongoException.java Show resolved Hide resolved

stIncMale commented Mar 31, 2021

View reviewed changes

driver-core/src/main/com/mongodb/MongoInterruptedException.java Show resolved Hide resolved

stIncMale added 3 commits March 31, 2021 19:16

Undo changes in the ConnectionPoolListener specification

fa3c23c

JAVA-3927

Improve docs

0fedc2d

JAVA-3927

Add concurrency tests for DefaultConnectionPool

22d3afc

JAVA-3927

stIncMale force-pushed the JAVA-3927 branch from 221be52 to 22d3afc Compare April 3, 2021 06:13

stIncMale requested a review from jyemin April 3, 2021 06:13

stIncMale added 2 commits April 5, 2021 09:21

Assert all checked in connections are handed over in DefaultConnectio…

fbdd763

…nPool.checkoutHandOverMechanism JAVA-3927

Address review concerns

ba98f3d

JAVA-3927

jyemin reviewed Apr 6, 2021

View reviewed changes

Do not confuse a user with timeout exceptions caused by timeout excep…

b04ff8f

…tions JAVA-3927

stIncMale requested a review from jyemin April 6, 2021 20:54

jyemin approved these changes Apr 6, 2021

View reviewed changes

rozza approved these changes Apr 13, 2021

View reviewed changes

stIncMale merged commit ead0357 into mongodb:master Apr 14, 2021

stIncMale deleted the JAVA-3927 branch April 14, 2021 18:53

stIncMale restored the JAVA-3927 branch April 14, 2021 19:15

stIncMale deleted the JAVA-3927 branch April 25, 2021 14:01

stIncMale mentioned this pull request Apr 27, 2021

Fix deadlock and couple more problems in DefaultConnectionPool #699

Merged

Rate limit new connection creations (maxConnecting) #685

Rate limit new connection creations (maxConnecting) #685

Uh oh!

Conversation

stIncMale commented Mar 16, 2021

Uh oh!

stIncMale commented Mar 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stIncMale commented Mar 18, 2021

Uh oh!

Uh oh!

rozza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyemin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyemin left a comment

Choose a reason for hiding this comment

Uh oh!

jyemin left a comment

Choose a reason for hiding this comment

Uh oh!

rozza left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stIncMale commented Mar 17, 2021 •

edited

Loading