-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Simplify DefaultConnectionPool.OpenConcurrencyLimiter.tryLock
#702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Simplify
DefaultConnectionPool.OpenConcurrencyLimiter.tryLock
When locking for the purpose of using the wait/signal approach, one does not have to account the time spent acquiring the lock towards the timeout. While doing so may reduce the non-deterministic duration by which a timeout is exceeded by any implementation of a timeout, such overtime is usually negligible, unless the lock is highly contended and/or checking the condition before starting to wait is time-consuming. The Java SE example for `java.util.concurrent.locks.Condition.awaitNanos` ignores the time spent acquiring the lock. Doing so potentially reduces responsiveness to timeouts, but does not affect other performance characteristics, so I believe such simplification is worth it and I should have taken this path initially. JAVA-3927
- Loading branch information
commit 3bce9e72ede62ca29cef3730d6d525f303377fcc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.