Fixed transaction issues with GridFS

[derickr]

This pull requests makes sure that chunks are removed when the gridfs meta file record can not be added (due to f.e. index issues). It also forces safe mode for the insertion of the gridfs meta file record.

[bjori]

Don't you need to separate the zval to not modify the original array here?

Infact.. I don't see where the input argument is ever forced as array?

[derickr]

On Mon, 20 Feb 2012, Hannes Magnusson wrote:

@@ -383,14 +430,30 @@ static void add_md5(zval *zfile, zval *zid, mongo_collection *c TSRMLS_DC) {
add_assoc_long(zfile, "length", bytes_len);
}

• // options
• if (!options) {

•   zval *opts;
  

•   MAKE_STD_ZVAL(opts);
  

•   array_init(opts);
  

•   options = opts;
  

•   free_options = 1;
  

• }

• // force safe mode
• add_assoc_long(options, "safe", 1);

Don't you need to separate the zval to not modify the original array here?

Hmm, good point :-)

Infact.. I don't see where the input argument is ever forced as array?

Also a good point. I noticed that in a lot of cases just a "z" is used
and not the actual. In this case however, changing "s|az" tp "s|as"
would be correct.

cheers,
Derick

http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug