fix: simplify version checking

src/cmap/handshake/client_metadata.ts

@@ -261,28 +261,13 @@ declare const Bun: { (): void; version?: string } | undefined;
  */
 function getRuntimeInfo(): string {
   if ('Deno' in globalThis) {
-    const version =
-      Deno != null &&
-      typeof Deno === 'object' &&
-      'version' in Deno &&
-      Deno.version != null &&
-      typeof Deno.version === 'object' &&
-      'deno' in Deno.version &&
-      typeof Deno.version.deno === 'string'
-        ? Deno.version.deno
-        : '0.0.0';
+    const version = typeof Deno?.version?.deno === 'string' ? Deno?.version?.deno : '0.0.0-unknown';
 
     return `Deno v${version}, ${os.endianness()}`;
   }
 
   if ('Bun' in globalThis) {
-    const version =
-      Bun != null &&
-      typeof Bun === 'function' &&
-      'version' in Bun &&
-      typeof Bun.version === 'string'
-        ? Bun.version
-        : '0.0.0';
+    const version = typeof Bun?.version === 'string' ? Bun?.version : '0.0.0-unknown';
 
     return `Bun v${version}, ${os.endianness()}`;
   }

test/unit/cmap/handshake/client_metadata.test.ts

@@ -311,31 +311,25 @@ describe('client metadata module', () => {
         it('ignores version if Deno.version.deno is not a string', () => {
           globalThis.Deno = { version: { deno: 1 } };
           const metadata = makeClientMetadata({ driverInfo: {} });
-          expect(metadata.platform).to.equal('Deno v0.0.0, LE');
-        });
-
-        it('ignores version if Deno.version.deno is not a string and sets driverInfo.platform', () => {
-          globalThis.Deno = { version: { deno: 1 } };
-          const metadata = makeClientMetadata({ driverInfo: { platform: 'myPlatform' } });
-          expect(metadata.platform).to.equal('Deno v0.0.0, LE|myPlatform');
+          expect(metadata.platform).to.equal('Deno v0.0.0-unknown, LE');
         });
 
         it('ignores version if Deno.version does not have a deno property', () => {
           globalThis.Deno = { version: { somethingElse: '1.2.3' } };
           const metadata = makeClientMetadata({ driverInfo: {} });
-          expect(metadata.platform).to.equal('Deno v0.0.0, LE');
+          expect(metadata.platform).to.equal('Deno v0.0.0-unknown, LE');
         });
 
         it('ignores version if Deno.version is null', () => {
           globalThis.Deno = { version: null };
           const metadata = makeClientMetadata({ driverInfo: {} });
-          expect(metadata.platform).to.equal('Deno v0.0.0, LE');
+          expect(metadata.platform).to.equal('Deno v0.0.0-unknown, LE');
         });
 
-        it('ignores version if Deno does not have a version property', () => {
-          globalThis.Deno = { version: null };
+        it('ignores version if Deno is nullish', () => {
+          globalThis.Deno = null;
           const metadata = makeClientMetadata({ driverInfo: {} });
-          expect(metadata.platform).to.equal('Deno v0.0.0, LE');
+          expect(metadata.platform).to.equal('Deno v0.0.0-unknown, LE');
         });
       });
 
@@ -365,21 +359,21 @@ describe('client metadata module', () => {
             static version = 1;
           };
           const metadata = makeClientMetadata({ driverInfo: {} });
-          expect(metadata.platform).to.equal('Bun v0.0.0, LE');
+          expect(metadata.platform).to.equal('Bun v0.0.0-unknown, LE');
         });
 
         it('ignores version if Bun.version is not a string and sets driverInfo.platform', () => {
           globalThis.Bun = class {
             static version = 1;
           };
           const metadata = makeClientMetadata({ driverInfo: { platform: 'myPlatform' } });
-          expect(metadata.platform).to.equal('Bun v0.0.0, LE|myPlatform');
+          expect(metadata.platform).to.equal('Bun v0.0.0-unknown, LE|myPlatform');
         });
 
-        it('ignores version if Bun is not a function', () => {
-          globalThis.Bun = { version: '1.2.3' };
+        it('ignores version if Bun is nullish', () => {
+          globalThis.Bun = null;
           const metadata = makeClientMetadata({ driverInfo: { platform: 'myPlatform' } });
-          expect(metadata.platform).to.equal('Bun v0.0.0, LE|myPlatform');
+          expect(metadata.platform).to.equal('Bun v0.0.0-unknown, LE|myPlatform');
         });
       });
     });