-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-5981): read preference not applied to commands properly #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nbbeeken
merged 31 commits into
main
from
NODE-5981-fix-applying-read-preference-to-command
Mar 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
b5d0f02
fix(NODE-5817): read preference not applied to commands properly
alenakhineika 1e4c377
test: remove a test case
alenakhineika 541b5d5
docs: update comments
alenakhineika 3304317
feat: pass directConnection from connection pool
alenakhineika 8b875ef
test: remove only
alenakhineika 2d033a3
fix: import type
alenakhineika 46f49ee
Merge branch 'main' into NODE-5981-fix-applying-read-preference-to-co…
alenakhineika 325cb58
fix: add options to unit tests
alenakhineika d65cd3a
test: sync run-command spec tests
alenakhineika f591d2e
fix: do not check direct connection
alenakhineika 9883c45
docs: update comment
alenakhineika 2de4e4d
fix: check for primary for all topologies
alenakhineika 2c20053
Merge branch 'main' into NODE-5981-fix-applying-read-preference-to-co…
alenakhineika 4193f7d
refactor: try to revert query
alenakhineika af78187
Merge branch 'main' into NODE-5981-fix-applying-read-preference-to-co…
alenakhineika 40a4847
test: exclude arbiter
alenakhineika 418513e
Merge branch 'NODE-5981-fix-applying-read-preference-to-command' of g…
alenakhineika 00978cb
Merge branch 'main' into NODE-5981-fix-applying-read-preference-to-co…
alenakhineika 1806f30
test: debug
alenakhineika a4685d9
Merge branch 'NODE-5981-fix-applying-read-preference-to-command' of g…
alenakhineika bb79b9b
test: skip when is not ReplicaSetWithPrimary
alenakhineika 250451e
test: debug
alenakhineika 5e57787
Merge branch 'main' into NODE-5981-fix-applying-read-preference-to-co…
alenakhineika cd9ecdf
test: compare with primary as a string
alenakhineika c9f5e10
Merge branch 'NODE-5981-fix-applying-read-preference-to-command' of g…
alenakhineika 4c82bb8
test: adress pr comments
alenakhineika f782630
Merge remote-tracking branch 'origin/main' into NODE-5981-fix-applyin…
alenakhineika 4c41b4e
fix: type
alenakhineika 61635b0
refactor(no-story): don't store directConnection on the connection po…
baileympearson 9b32b77
Merge branch 'main' into NODE-5981-fix-applying-read-preference-to-co…
baileympearson 4bee076
undo whitespace changes
nbbeeken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: exclude arbiter
- Loading branch information
commit 40a48476238330fd0175288bf9c12ba3ac49fe42
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.