Skip to content

feat(NODE-5762): include cause and package name for all MongoMissingDependencyErrors #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2024
Merged

feat(NODE-5762): include cause and package name for all MongoMissingDependencyErrors #4067

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a2dfb2e
add more descriptive error info
baileympearson Apr 3, 2024
b08f6d8
make cause required on missing dependency error
baileympearson Apr 3, 2024
44fba7e
make error required and move to ooptions
baileympearson Apr 3, 2024
b2deb30
Merge branch 'main' into NODE-5762
baileympearson Apr 3, 2024
9f87248
address PR comments
baileympearson Apr 4, 2024
45cca73
Update src/cmap/connection.ts
baileympearson Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/cmap/connection.ts 
Co-authored-by: Anna Henningsen <[email protected]>
  • Loading branch information
@baileympearson @addaleax
baileympearson and addaleax authored Apr 5, 2024
commit 45cca737cabcb60807ddf6249381a27f17deef34
2 changes: 1 addition & 1 deletion src/cmap/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ export class CryptoConnection extends Connection {
): Promise<Document> {
const { autoEncrypter } = this;
if (!autoEncrypter) {
// TODO(NODE-6065): throw a MongoMissingDependencyError in Node V7
// TODO(NODE-6065): throw a MongoRuntimeError in Node V7
// @ts-expect-error No cause provided because there is no underlying error.
throw new MongoMissingDependencyError('No AutoEncrypter available for encryption', {
dependencyName: 'n/a'
Expand Down