Skip to content

fix(NODE-6171): RTT set to zero when serverMonitoringMode=stream #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 15, 2024
Merged

fix(NODE-6171): RTT set to zero when serverMonitoringMode=stream #4110

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e501948
fix bug
W-A-James May 14, 2024
27f4de2
tighten types
W-A-James May 14, 2024
f7b5d0c
Add test to verify that rtt is never reported as zero for a successfu…
W-A-James May 14, 2024
1cc50d8
add tests
W-A-James May 14, 2024
b10242f
fix up tests
W-A-James May 14, 2024
2164899
collect more heartbeats
W-A-James May 14, 2024
0c923e7
add listener after connecting
W-A-James May 14, 2024
4126873
finalize tests
W-A-James May 14, 2024
71d414e
remove comment
W-A-James May 15, 2024
7dbe7a5
fix hanging test
W-A-James May 15, 2024
83f6546
clean up tests
W-A-James May 15, 2024
9c83722
loosen approximate assertion
W-A-James May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
collect more heartbeats
  • Loading branch information
@W-A-James
W-A-James committed May 14, 2024
commit 21648996795239ad5986a585d9cb2e3610e386a3
4 changes: 2 additions & 2 deletions test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('SDAM Unified Tests (Node Driver)', function () {
describe('Monitoring rtt tests', function () {
let client: MongoClient;
let windows: Record<string, number[][]>;
const THRESH = 100; // Wait for 100 total heartbeats. This is high enough to work for standalone, sharded and our typical 3-node replica set topology tests
const THRESH = 200; // Wait for 100 total heartbeats. This is high enough to work for standalone, sharded and our typical 3-node replica set topology tests
const SAMPLING_WINDOW_SIZE = 10;
let count: number;
const ee = new EventEmitter();
Expand Down Expand Up @@ -58,7 +58,7 @@ describe('Monitoring rtt tests', function () {
context(`when serverMonitoringMode is set to '${serverMonitoringMode}'`, function () {
beforeEach(async function () {
client = this.configuration.newClient({
heartbeatFrequencyMS: 500,
heartbeatFrequencyMS: 100,
connectTimeoutMS: 1000,
serverMonitoringMode
});
Expand Down