Skip to content

feat(NODE-6225): add property ownership check before referencing mongocryptdSpawnPath and mongocryptdSpawnArgs #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2024
Merged

feat(NODE-6225): add property ownership check before referencing mongocryptdSpawnPath and mongocryptdSpawnArgs #4151

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
898681b
fix: adding property existence check before referencing
vuusale Jun 16, 2024
2a60bd1
fix: check using hasOwn, add tests
durran Jun 27, 2024
b7743aa
test: use array
durran Jun 27, 2024
9e77586
fix: dont default multiple times
durran Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: dont default multiple times
  • Loading branch information
@durran
durran committed Jul 1, 2024
commit 9e77586e6a5b253a66dc5bfe664f540511cd9f7e
5 changes: 2 additions & 3 deletions src/client-side-encryption/mongocryptd_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ export class MongocryptdManager {

this.bypassSpawn = !!extraOptions.mongocryptdBypassSpawn;

if (Object.hasOwn(extraOptions, 'mongocryptdSpawnPath')) {
this.spawnPath = extraOptions.mongocryptdSpawnPath || '';
if (Object.hasOwn(extraOptions, 'mongocryptdSpawnPath') && extraOptions.mongocryptdSpawnPath) {
this.spawnPath = extraOptions.mongocryptdSpawnPath;
}
this.spawnArgs = [];
if (
Object.hasOwn(extraOptions, 'mongocryptdSpawnArgs') &&
Array.isArray(extraOptions.mongocryptdSpawnArgs)
Expand Down