Skip to content

fix(NODE-5720): on pre-4.4 sharded servers, the node driver uses error.writeConcern.code to determine retryability #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 30, 2024
Merged

fix(NODE-5720): on pre-4.4 sharded servers, the node driver uses error.writeConcern.code to determine retryability #4155

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6fd82f8
sync spec tests - no other changes needed
aditi-khare-mongoDB Jun 17, 2024
242c12d
remove stray only
aditi-khare-mongoDB Jun 17, 2024
a8f67d6
sharded <4.4 support
aditi-khare-mongoDB Jun 18, 2024
41e8587
remove typo
aditi-khare-mongoDB Jun 18, 2024
96b5c95
bugs fixed?
aditi-khare-mongoDB Jun 18, 2024
dcef868
remove stray only
aditi-khare-mongoDB Jun 18, 2024
f468ae4
skip outdated tests
aditi-khare-mongoDB Jun 20, 2024
e205a77
Merge branch 'main' into NODE-5720/clarify-retryable-fields
aditi-khare-mongoDB Jun 20, 2024
b22466e
skip tests
aditi-khare-mongoDB Jun 28, 2024
9eb063e
remove stray only
aditi-khare-mongoDB Jun 28, 2024
231fb80
Merge branch 'main' into NODE-5720/clarify-retryable-fields
aditi-khare-mongoDB Jun 28, 2024
e7037e9
skip tests with comment
aditi-khare-mongoDB Jul 9, 2024
440bac7
Merge branch 'main' into NODE-5720/clarify-retryable-fields
aditi-khare-mongoDB Jul 9, 2024
ad5b150
remove stray only
aditi-khare-mongoDB Jul 9, 2024
60ad9ac
fix logic
aditi-khare-mongoDB Jul 10, 2024
a7b760d
Merge branch 'main' into NODE-5720/clarify-retryable-fields
aditi-khare-mongoDB Jul 10, 2024
985dc03
changes to consider top-level code, doesnt pass tests
aditi-khare-mongoDB Jul 11, 2024
ac247a7
delete extraneous folder
aditi-khare-mongoDB Jul 11, 2024
10578d2
Merge branch 'main' into NODE-5720/clarify-retryable-fields
aditi-khare-mongoDB Jul 19, 2024
021e118
lint fix
aditi-khare-mongoDB Jul 19, 2024
fca53fe
Merge branch 'main' into NODE-5720/clarify-retryable-fields
aditi-khare-mongoDB Jul 29, 2024
7a1964b
post node-6276 update
aditi-khare-mongoDB Jul 29, 2024
a0bdcf4
post node-6276 update 2
aditi-khare-mongoDB Jul 29, 2024
5f8020e
requested changes
aditi-khare-mongoDB Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove stray only
  • Loading branch information
@aditi-khare-mongoDB
aditi-khare-mongoDB committed Jun 28, 2024
commit 9eb063ef756aef13f2774d3b06d188444ed6dacf
2 changes: 1 addition & 1 deletion test/integration/retryable-writes/retryable_writes.spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface RetryableWriteTestContext {
failPointName?: any;
}

describe.only('Legacy Retryable Writes Specs', function () {
describe('Legacy Retryable Writes Specs', function () {
let ctx: RetryableWriteTestContext = {};

const retryableWrites = loadSpecTests('retryable-writes', 'legacy');
Expand Down