Skip to content

feat(NODE-6350): add typescript support to client bulkWrite API #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 20, 2024
Merged

feat(NODE-6350): add typescript support to client bulkWrite API #4257

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8b309e2
feat(NODE-6350): add typescript support to client bulkWrite API
nbbeeken Sep 30, 2024
80a8b38
feat: add acknowledged to result
durran Oct 14, 2024
7acf218
test: fix ts in prose test
durran Oct 14, 2024
bac621a
test: fix unit test
durran Oct 14, 2024
b766cc3
feat: make bulk result readonly
durran Oct 14, 2024
94a5f24
fix: prose test
durran Oct 15, 2024
ed65e4f
docs: add namespace documentation
nbbeeken Oct 16, 2024
7da726a
Merge branch 'main' into NODE-6350-ts-clientBulkWrite
nbbeeken Oct 16, 2024
0658de4
docs: A mapping of namespace strings to collections schemas.
nbbeeken Oct 16, 2024
3714c11
chore: ClientBulkWriteResultAccumulation
nbbeeken Oct 16, 2024
4a783f3
chore: test fix
nbbeeken Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix ts in prose test
  • Loading branch information
@durran
durran committed Oct 14, 2024
commit 7acf218c3d55807366cba2cc4804b39616cc6f87
32 changes: 16 additions & 16 deletions test/integration/crud/crud.prose.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { once } from 'events';

import { type CommandStartedEvent } from '../../../mongodb';
import {
type AnyClientBulkWriteModel,
type ClientBulkWriteModel,
type ClientSession,
type Collection,
type Document,
Expand Down Expand Up @@ -176,7 +176,7 @@ describe('CRUD Prose Spec Tests', () => {
// firstEvent.operationId is equal to secondEvent.operationId.
let client: MongoClient;
let maxWriteBatchSize;
let models: AnyClientBulkWriteModel<Document>[] = [];
let models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down Expand Up @@ -244,7 +244,7 @@ describe('CRUD Prose Spec Tests', () => {
let maxBsonObjectSize;
let maxMessageSizeBytes;
let numModels;
let models: AnyClientBulkWriteModel<Document>[] = [];
let models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down Expand Up @@ -315,7 +315,7 @@ describe('CRUD Prose Spec Tests', () => {
// Assert that two CommandStartedEvents were observed for the bulkWrite command.
let client: MongoClient;
let maxWriteBatchSize;
let models: AnyClientBulkWriteModel<Document>[] = [];
let models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down Expand Up @@ -383,15 +383,15 @@ describe('CRUD Prose Spec Tests', () => {
// Construct a list of write models (referred to as models) with model repeated maxWriteBatchSize + 1 times.
let client: MongoClient;
let maxWriteBatchSize;
let models: AnyClientBulkWriteModel<Document>[] = [];
let models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
client = this.configuration.newClient({}, { monitorCommands: true, retryWrites: false });
await client.connect();
await client.db('db').collection('coll').drop();
const hello = await client.db('admin').command({ hello: 1 });
await client.db('db').collection('coll').insertOne({ _id: 1 });
await client.db('db').collection<{ _id?: number }>('coll').insertOne({ _id: 1 });
maxWriteBatchSize = hello.maxWriteBatchSize;

client.on('commandStarted', filterForCommands('bulkWrite', commands));
Expand Down Expand Up @@ -472,7 +472,7 @@ describe('CRUD Prose Spec Tests', () => {
// Assert that a CommandStartedEvent was observed for the getMore command.
let client: MongoClient;
let maxBsonObjectSize;
const models: AnyClientBulkWriteModel<Document>[] = [];
const models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down Expand Up @@ -546,7 +546,7 @@ describe('CRUD Prose Spec Tests', () => {
let client: MongoClient;
let session: ClientSession;
let maxBsonObjectSize;
const models: AnyClientBulkWriteModel<Document>[] = [];
const models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down Expand Up @@ -633,7 +633,7 @@ describe('CRUD Prose Spec Tests', () => {
// Assert that a CommandStartedEvent was observed for the killCursors command.
let client: MongoClient;
let maxBsonObjectSize;
const models: AnyClientBulkWriteModel<Document>[] = [];
const models: ClientBulkWriteModel<Document>[] = [];
const getMoreCommands: CommandStartedEvent[] = [];
const killCursorsCommands: CommandStartedEvent[] = [];

Expand Down Expand Up @@ -804,7 +804,7 @@ describe('CRUD Prose Spec Tests', () => {
let opsBytes;
let numModels;
let remainderBytes;
let models: AnyClientBulkWriteModel<Document>[] = [];
let models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down Expand Up @@ -860,7 +860,7 @@ describe('CRUD Prose Spec Tests', () => {
it('executes in a single batch', {
metadata: { requires: { mongodb: '>=8.0.0', serverless: 'forbid' } },
async test() {
const sameNamespaceModel: AnyClientBulkWriteModel<Document> = {
const sameNamespaceModel: ClientBulkWriteModel<Document> = {
name: 'insertOne',
namespace: 'db.coll',
document: { a: 'b' }
Expand Down Expand Up @@ -897,7 +897,7 @@ describe('CRUD Prose Spec Tests', () => {
metadata: { requires: { mongodb: '>=8.0.0', serverless: 'forbid' } },
async test() {
const namespace = `db.${'c'.repeat(200)}`;
const newNamespaceModel: AnyClientBulkWriteModel<Document> = {
const newNamespaceModel: ClientBulkWriteModel<Document> = {
name: 'insertOne',
namespace: namespace,
document: { a: 'b' }
Expand Down Expand Up @@ -951,7 +951,7 @@ describe('CRUD Prose Spec Tests', () => {
it('raises a client error', {
metadata: { requires: { mongodb: '>=8.0.0', serverless: 'forbid' } },
async test() {
const model: AnyClientBulkWriteModel<Document> = {
const model: ClientBulkWriteModel<Document> = {
name: 'insertOne',
namespace: 'db.coll',
document: { a: 'b'.repeat(maxMessageSizeBytes) }
Expand All @@ -977,7 +977,7 @@ describe('CRUD Prose Spec Tests', () => {
metadata: { requires: { mongodb: '>=8.0.0', serverless: 'forbid' } },
async test() {
const namespace = `db.${'c'.repeat(maxMessageSizeBytes)}`;
const model: AnyClientBulkWriteModel<Document> = {
const model: ClientBulkWriteModel<Document> = {
name: 'insertOne',
namespace: namespace,
document: { a: 'b' }
Expand Down Expand Up @@ -1034,7 +1034,7 @@ describe('CRUD Prose Spec Tests', () => {
});

it('raises a client side error', async function () {
const model: AnyClientBulkWriteModel<Document> = {
const model: ClientBulkWriteModel<Document> = {
name: 'insertOne',
namespace: 'db.coll',
document: { a: 'b' }
Expand Down Expand Up @@ -1114,7 +1114,7 @@ describe('CRUD Prose Spec Tests', () => {
let maxBsonObjectSize;
let maxMessageSizeBytes;
let numModels;
let models: AnyClientBulkWriteModel<Document>[] = [];
let models: ClientBulkWriteModel<Document>[] = [];
const commands: CommandStartedEvent[] = [];

beforeEach(async function () {
Expand Down