Skip to content

feat(NODE-6338): implement client bulk write error handling #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Oct 10, 2024
Merged

feat(NODE-6338): implement client bulk write error handling #4262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
027b547
feat(NODE-6338): implement client bulk write error handling
durran Sep 26, 2024
d713a3d
chore: comments
durran Oct 4, 2024
3c2bd61
fix: exports
durran Oct 4, 2024
ccd25a1
test: make retryable
durran Oct 4, 2024
461a9eb
fix: tests
durran Oct 4, 2024
6182bd1
fix: batch reset on retry
durran Oct 7, 2024
94463ed
fix: write concern error results
durran Oct 7, 2024
4d57b89
chore: console
durran Oct 7, 2024
2fe5d23
chore: debug
durran Oct 7, 2024
03de031
fix: check if retryable
durran Oct 7, 2024
2200ff3
chore: debug
durran Oct 7, 2024
6832248
Revert "chore: debug"
durran Oct 7, 2024
26b40f8
chore: debug
durran Oct 7, 2024
b1ab86e
fix: use cause
durran Oct 7, 2024
3f81c38
test: sync tests
durran Oct 7, 2024
77022eb
fix: lb pinning
durran Oct 7, 2024
ba49071
fix: lb leak
durran Oct 7, 2024
90ed030
chore: debug pinning
durran Oct 8, 2024
fb4cbb1
fix: always unpin
durran Oct 8, 2024
2093596
fix: pin in finally
durran Oct 8, 2024
d2d535f
chore: remove debug
durran Oct 8, 2024
4ecbf5f
chore: comments
durran Oct 8, 2024
bddc0b2
fix: second size check
durran Oct 9, 2024
9602855
fix: retry on batches
durran Oct 9, 2024
f4f35d8
chore: debug retry
durran Oct 9, 2024
53dc9fc
test: throw in loop
durran Oct 9, 2024
df7d4aa
test: run all tests
durran Oct 9, 2024
7f95974
chore: comments
durran Oct 9, 2024
f8e5c1f
chore: add cause to invalid argument error
durran Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: sync tests
  • Loading branch information
@durran
durran committed Oct 8, 2024
commit 3f81c38967cba936166991cc4b70b6083b1c29d8
8 changes: 5 additions & 3 deletions test/spec/retryable-writes/unified/handshakeError.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"description": "retryable writes handshake failures",
"schemaVersion": "1.3",
"schemaVersion": "1.4",
"runOnRequirements": [
{
"minServerVersion": "4.2",
Expand Down Expand Up @@ -57,7 +57,8 @@
"description": "client.clientBulkWrite succeeds after retryable handshake network error",
"runOnRequirements": [
{
"minServerVersion": "8.0"
"minServerVersion": "8.0",
"serverless": "forbid"
}
],
"operations": [
Expand Down Expand Up @@ -165,7 +166,8 @@
"description": "client.clientBulkWrite succeeds after retryable handshake server error (ShutdownInProgress)",
"runOnRequirements": [
{
"minServerVersion": "8.0"
"minServerVersion": "8.0",
"serverless": "forbid"
}
],
"operations": [
Expand Down
4 changes: 3 additions & 1 deletion test/spec/retryable-writes/unified/handshakeError.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

description: "retryable writes handshake failures"

schemaVersion: "1.3"
schemaVersion: "1.4" # For `serverless: forbid`

runOnRequirements:
- minServerVersion: "4.2"
Expand Down Expand Up @@ -53,6 +53,7 @@ tests:
- description: "client.clientBulkWrite succeeds after retryable handshake network error"
runOnRequirements:
- minServerVersion: "8.0" # `bulkWrite` added to server 8.0
serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down Expand Up @@ -98,6 +99,7 @@ tests:
- description: "client.clientBulkWrite succeeds after retryable handshake server error (ShutdownInProgress)"
runOnRequirements:
- minServerVersion: "8.0" # `bulkWrite` added to server 8.0
serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down