Skip to content

fix(NODE-6436): only force majority write concern on commitTransaction retry #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2024
Merged

fix(NODE-6436): only force majority write concern on commitTransaction retry #4284

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cccb3b9
only force majority write concern on commitTransaction retry
W-A-James Oct 17, 2024
2411c43
add int test
W-A-James Oct 17, 2024
ca48b61
add doc comment
W-A-James Oct 17, 2024
3c8707e
pre-create collection
W-A-James Oct 17, 2024
79967fc
pre-drop collection
W-A-James Oct 17, 2024
bf4b60d
remove log
W-A-James Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pre-create collection
  • Loading branch information
@W-A-James
W-A-James committed Oct 17, 2024
commit 3c8707e472ef9361057f4c036679190914f07aec
3 changes: 2 additions & 1 deletion test/integration/transactions/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,12 @@ describe('Transactions', function () {
'commitTransaction does not override write concern on initial attempt',
{ requires: { mongodb: '>=4.2.0', topology: '!single' } },
async function () {
const collection = await client.db('test').createCollection('test');
const session = client.startSession({
defaultTransactionOptions: { writeConcern: { w: 1 } }
});
session.startTransaction();
await client.db('test').collection('test').insertOne({ x: 1 }, { session });
await collection.insertOne({ x: 1 }, { session });
await session.commitTransaction();

const commitTransactions = commandsStarted.filter(
Expand Down