Drop support for Mongoid 6 and Ruby 2.4 #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mongoid 6 and earlier - Ruby 2.4 and earlier
- Remove gem Guard - Remove gem AwesomePrint - Remove gem mongoid-compatibility - Set version to 7.0.0
Collaborator
|
Do we have to? I mean is there anything broken on 6 rn that adds to maintenance or anything we want to deprecate? I use 6 all over the place still for one ;) |
dblock
approved these changes
Aug 12, 2021
Collaborator
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
You answered my question in #267 (comment), we can drop support for these. Amend the CHANGELOG and this LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
This PR drops support for:
Note that Ruby 2.4 and earlier are EOL.