Skip to content

Security Fix for Prototype Pollution #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ready-research wants to merge 2 commits into from
Closed

Security Fix for Prototype Pollution #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed8745
Security Fix for Prototype Pollution
ready-research Aug 31, 2021
d497faa
Merge pull request #1 from ready-research/ready-research-Prototype-Po…
ready-research Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Security Fix for Prototype Pollution 
Fix prototype pollution when path components are not strings
  • Loading branch information
@ready-research
ready-research authored Aug 31, 2021
commit 2ed8745f931b0a9d523beb61d5bb20cfd88a3b2b
8 changes: 7 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ exports.unset = function(path, o) {
if (cur == null || typeof cur !== 'object' || !(parts[i] in cur)) {
return false;
}
if (typeof parts[i] !== 'string' && typeof parts[i] !== 'number') {
parts[i] = String(parts[i]);
}
// Disallow any updates to __proto__ or special properties.
if (ignoreProperties.indexOf(parts[i]) !== -1) {
return false;
Expand Down Expand Up @@ -193,6 +196,9 @@ exports.set = function(path, val, o, special, map, _copying) {
if (null == o) return;

for (var i = 0; i < parts.length; ++i) {
if (typeof parts[i] !== 'string' && typeof parts[i] !== 'number') {
parts[i] = String(parts[i]);
}
// Silently ignore any updates to `__proto__`, these are potentially
// dangerous if using mpath with unsanitized data.
if (ignoreProperties.indexOf(parts[i]) !== -1) {
Expand Down Expand Up @@ -311,4 +317,4 @@ function _setArray(obj, val, part, lookup, special, map) {

function K(v) {
return v;
}
}