Skip to content

Order lastname and middlename parameters correctly for contact->setName call #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asbiin merged 3 commits into from
Mar 30, 2018
Merged

Order lastname and middlename parameters correctly for contact->setName call #1073

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dda96c8
order lastname and middlename parameters correctly for contact->setName
EQuineOntology Mar 30, 2018
7fda575
Remove superfluous parameter in contact->setName call
EQuineOntology Mar 30, 2018
6736384
Merge branch 'master' into edit-contact-error
asbiin Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Http/Controllers/ContactsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ public function update(Request $request, Contact $contact)
->withErrors($validator);
}

if (! $contact->setName($request->input('firstname'), null, $request->input('lastname'))) {
if (! $contact->setName($request->input('firstname'), $request->input('lastname'), null)) {
Copy link
Member

@asbiin asbiin Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the null value here, because the third parameter of setName is optionnal.

return back()
->withInput()
->withErrors('There has been a problem with saving the name.');
Expand Down