Skip to content

Fix contact deletion #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asbiin merged 3 commits into from
Apr 7, 2018
Merged

Fix contact deletion #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2190f6e
Fix contact deletion
asbiin Apr 7, 2018
ef4093a
Add a test
asbiin Apr 7, 2018
08618c6
Fix StyleCI
asbiin Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/Contact.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,8 @@ public function deleteEverything()
}
}

$this->delete();

return true;
}

Expand Down
14 changes: 14 additions & 0 deletions tests/Unit/ContactTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,4 +1121,18 @@ public function test_it_fetches_the_partial_contact_who_belongs_to_a_real_contac
$foundContact->id
);
}

public function test_contact_deletion()
{
$account = factory('App\Account')->create([]);
$contact = factory(Contact::class)->create(['account_id' => $account->id]);
$contact->save();
$id = $contact->id;

$this->assertEquals(1, Contact::where('id', $id)->count());

$contact->deleteEverything();

$this->assertEquals(0, Contact::where('id', $id)->count());
}
}