Skip to content

style: Final colour simplification #5021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asbiin merged 33 commits into from
Sep 6, 2021
Merged

style: Final colour simplification #5021

asbiin merged 33 commits into from
Sep 6, 2021

Conversation

@mgrhm
Copy link

@mgrhm mgrhm commented Mar 30, 2021 •
edited
Loading

This pull further simplifies the colour palette from 25 colours to 19. It simplifies the palette and code. Once this is merged, I'll be able to start work on the dark mode (#1192).

There are quite a lot of small, separate commits in this. A summary of the main changes:

  • Six near-neighbour or one-use colours removed
  • All hex code colours are now six character
  • All word-named colours are now hex codes
  • All RGBA colours are now hex codes

mgrhm added 27 commits March 29, 2021 10:49
@mgrhm
style: Changed pale red to be paler for better contrast.
8792016
@mgrhm
style: Added darker borders on warning and danger button hover.
469b0e0
@mgrhm
style: Replaced #e5e5e5 with #d0d0d0 (only two uses).
a3b5ff1
@mgrhm
chore: Removed unused background from svg class.
0d143d1
@mgrhm
chore: Standardised all #fff instances to #ffffff.
0ffef90
@mgrhm
chore: Standardised all #eee instances to #eeeeee.
ebad347
@mgrhm
style: Replaced #ddd with #d0d0d0.
d7ff51a
@mgrhm
chore: Standardised all monicahq#999 instances to #999999.
9d50db9
@mgrhm
style: Replaced monicahq#333 with #313436.
a82b5a7
@mgrhm
style: Replaced #ccc with #d0d0d0 (only one use).
2af901b
@mgrhm
style: Replaced monicahq#900 with #b22222 (only one use).
c4b7c7d
@mgrhm
style: Replaced monicahq#777 with #999999 (only one use).
be924b1
@mgrhm
Merge remote-tracking branch 'upstream/master' into further-colour-si…
0f94680 
…mplification
@mgrhm
style: Updated background and border colours on edit boxes.
0210674
@mgrhm
style: Replaced RGBA colours with hex codes in app-ltr.sass.
6c3bd17
@mgrhm
style: Replaced RGBA colours with hex codes in buttons.scss.
c5b61c9
@mgrhm
style: Replaced RGBA colour with hex codes in header.scss
9f12e3b 
I haven't changed two of the RGBA values as these won't need to be
changed for dark mode.
@mgrhm
style: Replaced RGBA colour with hex codes in modal.scss.
bcdbdf3
@mgrhm
style: Replaced RGBA colour with hex codes in people.scss.
4ef0ada
@mgrhm
style: Replaced RGBA colour with hex codes in stripe.scss.
c7c4a8b
@mgrhm
style: Replaced #dcdcdc with #d0d0d0 (six instances).
6fdda6f
@mgrhm
style: Removed two one-use colours (#47c1bf, #58748c).
e962f87
@mgrhm
fix: Removed stray closing brace.
0e2e042
@mgrhm
style: Replaced "white" with #ffffff hex-code.
c8bcf75
@mgrhm
style: Removed RGBA and RGB values in header.scss.
7f0b85a
@mgrhm
chore: Added updated CSS and JSON files.
c0f5d02
@mgrhm
style: Reduced opacity of placeholder text in search box.
5504a0d
@mgrhm mgrhm changed the title Final colour simplification style: Final colour simplification Apr 3, 2021
asbiin
asbiin approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's really nice like that!
Don't you want to create variables for every colors in 1 file, and use these variables everywhere?

@mgrhm
Copy link
Author

mgrhm commented Apr 27, 2021

I'd planned to do exactly that in the 'final' colour commit where I implement a dark mode.

@asbiin asbiin temporarily deployed to monica-team-further-col-zuvm6l April 28, 2021 19:12 Inactive
@mgrhm
Copy link
Author

mgrhm commented Aug 25, 2021

Hi @asbiin. I've removed the compiled CSS and JSON assets from this pull request.

Do you need me to do anything else before you can merge?

@asbiin
Copy link
Member

asbiin commented Aug 26, 2021

@mgrhm there was still some files to remove, but I've fixed it. I will start reviewing this now! Thanks!

@asbiin asbiin temporarily deployed to monica-team-further-col-mmldhe August 26, 2021 20:53 Inactive
asbiin
asbiin requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mgrhm ! Hope to see the next one;)
See my comment here:

@mgrhm mgrhm requested a review from asbiin September 2, 2021 19:22
asbiin
asbiin approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@asbiin asbiin merged commit d44c183 into monicahq:master Sep 6, 2021
@asbiin
Copy link
Member

asbiin commented Sep 6, 2021

@mgrhm Thank you so much, your changes are much appreciate

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Oct 10, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asbiin asbiin asbiin approved these changes

Assignees

No one assigned

Labels

released reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgrhm @asbiin