-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Run tests using postgres as well #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution! It's definitely a first good step to have this check in Travis. I can't review this at this time but I will in the coming days. Thanks for your patience! |
|
@simhnna the build fails on Travis for this. I have no clue about Postgre unfortunately. |
|
Now the infrastructure for postgres is well configured. The current errors are from migrations that are only valid for mysql. These need to be changed so they are also valid for postgresql. The current errors are issues that are already created in the bugtracker: I'm not sure why raw sql statements are used in the first place, but then again I don't know enough about the internals of monica. The mysql build fails because of something in the |
|
@asbiin do you know why |
asbiin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, we should to this, and perhaps a mix with #785 too ...
.env.postgres.travis
Outdated
| APP_ENV=testing | ||
| APP_KEY=base64:NTrXToqFZJlv48dgPc+kNpc3SBt333TfDnF1mDShsBg= | ||
|
|
||
| DB_CONNECTION=pgsql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should propose a new "pgsqltesting" connection configuration instead, using DB_TEST_* variables, like the "testing" configuration in config/database.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asbiin you are welcome to take over. I'm not using monica anymore (partly because of the database issues)
|
This pull request has been automatically locked since there |
I'm not sure if this will actually build for postgres, but I guess it's a start. If it doesn't and someone knows how to get it running please take over. I'm not a laravel dev, so I really have no idea...
I would really like it if monica wouldn't only be usable with mysql but also with postgres and also sqlite. I don't see a reason why not, CI shoud be able to take care of incompatibilites and alert about them...