Skip to content

Conversation

@simhnna
Copy link

@simhnna simhnna commented Dec 12, 2017

I'm not sure if this will actually build for postgres, but I guess it's a start. If it doesn't and someone knows how to get it running please take over. I'm not a laravel dev, so I really have no idea...

I would really like it if monica wouldn't only be usable with mysql but also with postgres and also sqlite. I don't see a reason why not, CI shoud be able to take care of incompatibilites and alert about them...

@djaiss
Copy link
Member

djaiss commented Dec 14, 2017

Thanks a lot for your contribution! It's definitely a first good step to have this check in Travis.

I can't review this at this time but I will in the coming days. Thanks for your patience!

@djaiss
Copy link
Member

djaiss commented Jan 8, 2018

@simhnna the build fails on Travis for this. I have no clue about Postgre unfortunately.

@simhnna
Copy link
Author

simhnna commented Jan 9, 2018

Now the infrastructure for postgres is well configured. The current errors are from migrations that are only valid for mysql. These need to be changed so they are also valid for postgresql.

The current errors are issues that are already created in the bugtracker:

I'm not sure why raw sql statements are used in the first place, but then again I don't know enough about the internals of monica.

The mysql build fails because of something in the travis_sonar.sh but it provides absolutley no output, so there is no way for me to know what the issue is.

@djaiss
Copy link
Member

djaiss commented Jan 13, 2018

@asbiin do you know why travis_sonar.sh raises an error here?

asbiin
asbiin previously requested changes Feb 1, 2018
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, we should to this, and perhaps a mix with #785 too ...

APP_ENV=testing
APP_KEY=base64:NTrXToqFZJlv48dgPc+kNpc3SBt333TfDnF1mDShsBg=

DB_CONNECTION=pgsql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should propose a new "pgsqltesting" connection configuration instead, using DB_TEST_* variables, like the "testing" configuration in config/database.php

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asbiin you are welcome to take over. I'm not using monica anymore (partly because of the database issues)

@asbiin asbiin dismissed their stale review February 2, 2018 09:25

OK I will try it, thanks !

asbiin added a commit that referenced this pull request Feb 2, 2018
@asbiin asbiin closed this in #785 Feb 3, 2018
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants