Skip to content

Conversation

@asbiin
Copy link
Member

@asbiin asbiin commented Jan 29, 2018

This should close #800 and close #30 and close #136

js, css, and fonts assets are now built on travis before running tests.
Result of build is published on bintray here:
https://bintray.com/monicahq/builds
https://bintray.com/monicahq/docker

Deploy is done for master branch only.

I have changed the docker archive a little as nodejs and composer are not needed in the docker image anymore.

Monica's developers will have to run

make build-dev

to create the same assets, every time packages.json is updated.

@asbiin asbiin changed the title Build and publish assets to bintray [wip] Build and publish assets to bintray Jan 29, 2018
@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #865 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   27.43%   27.43%           
=======================================
  Files         177      177           
  Lines        4880     4880           
=======================================
  Hits         1339     1339           
  Misses       3541     3541

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57c684...6ccd691. Read the comment docs.

@asbiin asbiin changed the title [wip] Build and publish assets to bintray Build and publish assets to bintray Feb 2, 2018
@asbiin
Copy link
Member Author

asbiin commented Feb 2, 2018

@asbiin asbiin changed the title Build and publish assets to bintray Build and publish assets to bintray [wip] Feb 4, 2018
@asbiin
Copy link
Member Author

asbiin commented Feb 5, 2018

This PR should wait #884 to be released.

@asbiin
Copy link
Member Author

asbiin commented Apr 16, 2018

This is done.

@asbiin asbiin closed this Apr 16, 2018
@asbiin asbiin deleted the features/800-remove-assets branch April 16, 2018 22:16
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

2 participants