Skip to content

Add git to Docker image (#947) #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tlvince wants to merge 1 commit into from
Closed

Add git to Docker image (#947) #948

tlvince wants to merge 1 commit into from

Conversation

@tlvince
Copy link

@tlvince tlvince commented Feb 28, 2018

Closes #947.

@asbiin
Copy link
Member

asbiin commented Feb 28, 2018

We should not add git to the docker image.

@djaiss
Copy link
Member

djaiss commented Mar 1, 2018

@asbiin can you explain why?

@asbiin
Copy link
Member

asbiin commented Mar 1, 2018

@djaiss The message is related to #872, but it's not an error, and #872 is fixed now.
Also, adding git will not be usefull as the .git directory is no longer part of docker image !

The message will no longer be displayed in the next release.

@tlvince
Copy link
Author

tlvince commented Mar 1, 2018

Closed by #950.

@tlvince tlvince closed this Mar 1, 2018
@github-actions
Copy link

github-actions bot commented Feb 13, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docker] sh: git: not found on php artisan calls

3 participants

@tlvince @asbiin @djaiss