Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@JoshOrndorff
Copy link
Contributor

This PR updates the dependencies and the Rust toolchain.

This unblocks #26 which I'll also tackle now.

@JoshOrndorff
Copy link
Contributor Author

JoshOrndorff commented Aug 23, 2021

So the benchmarks seem not to be working / building. I can reproduce the error from the CI with cargo test --features runtime-benchmarks but I'm not sure what I did to break that or how to fix it.

@girazoki
Copy link
Contributor

This branch now fails in the fmt too. So far I have been able to figure out that:

@girazoki
Copy link
Contributor

girazoki commented Sep 1, 2021

This can be merged now

Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a quick question that was worth reviewing.

Also, we may want to re-run benchmarks after our deps update. I can do that, just let me know when.

@girazoki girazoki merged commit 0d7f6fd into main Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants