Make author inherent both required and mandatory #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4meta5
reviewed
Jan 27, 2021
JoshOrndorff
commented
Jan 28, 2021
Comment on lines
+189
to
+196
| fn is_inherent_required(_: &InherentData) -> Result<Option<Self::Error>, Self::Error> { | ||
| // Return Ok(Some(_)) unconditionally because this inherent is required in every block | ||
| // If it is not found, throw an AuthorInherentRequired error. | ||
| Ok(Some(InherentError::Other( | ||
| sp_runtime::RuntimeString::Borrowed("AuthorInherentRequired"), | ||
| ))) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@4meta5 This is why I was wondering whether we still need the check in on_finalize.
See paritytech/substrate#7941 for my best understanding of how this trait works.
Contributor
There was a problem hiding this comment.
I see. This should work, but still need to clear the storage item in on_finalize so it can be set in the next block. So can remove the assert!(<Author>::take) and replace it with <Author>::kill()
Contributor
Author
There was a problem hiding this comment.
@4meta5 Could you please investigate whether this cleanup is valid in another PR?
crystalin
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Modifies the author inherent in two ways.
What important points reviewers should know?
We discovered the need for this change when we tried to install the democracy pallet. Democracy intentionally fills the entire block weight every
LaunchPeriodblocks. This was leaving no room for the inherent which was dropped. That made our blocks invalid.What alternative implementations were considered?
As always, we may ditch the author inherent for a PReRuntime digest when cumulus supports slots (or we may not). But regardless of whether we use this inherent long-term, this is the correct design for it.
What value does it bring to the blockchain users?
The chain doesn't stall after the first launch period.
Checklist