-
Notifications
You must be signed in to change notification settings - Fork 384
Attempt to integrate nimbus without keystore support #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR got derailed into an attempt to add part of nimbus without adding all of it. Other bugs were fixed along the way, so I'll close this for now. Let's keep the branch just in case this is ever useful. It may be that this is a valid usecase for nimbus in which case I'll need to move som code from this branch back over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates cumulus dependencies to latest
rococo-v1branches, and strives to bring in the nimbus consensus framework (as opposed to the original PoC crates that we sketched here). Currently the PoC crates are still in use.Target dependencies are:
What important points reviewers should know?
This is using a fork of cumulus (my
nimbusbranch). It remains to be seen whether nimbus will be accepted into cumulus, or move to its own repo, but either way the long-term plan is not to maintain a fork.Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
Basti's ongoing effort to wire sc-consensus-aura into the parachain context paritytech/cumulus#371
Checklist