Skip to content

Fix the wasm substitute caching bug #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
librelois merged 2 commits into from
Jul 27, 2023
Merged

Fix the wasm substitute caching bug #64

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3bc87a
Fix the wasm runtime substitute caching bug (#2514)
Jul 27, 2023
a5f553e
Apply changes from review comments
Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/service/src/client/wasm_substitutes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,13 @@ where
let substitutes = substitutes
.into_iter()
.map(|(block_number, code)| {
let mut hasher = DefaultHasher::new();
Copy link

@librelois librelois Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let mut hasher = DefaultHasher::new();

Copy link
Author

@rimbi rimbi Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks 👍

hasher.write(&code);
Copy link

@librelois librelois Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hasher.write(&code);

Copy link
Author

@rimbi rimbi Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks 👍

let hash = hasher.finish().to_ne_bytes().to_vec();
Copy link

@librelois librelois Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let hash = hasher.finish().to_ne_bytes().to_vec();

Copy link
Author

@rimbi rimbi Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks 👍

let runtime_code = RuntimeCode {
code_fetcher: &WrappedRuntimeCode((&code).into()),
heap_pages: None,
hash: Vec::new(),
hash,
Copy link

@librelois librelois Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hash,
hash: make_hash(&code),

Copy link
Author

@rimbi rimbi Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks 👍

};
let version = Self::runtime_version(&executor, &runtime_code)?;
let spec_version = version.spec_version;
Expand Down