Skip to content

Add XcmPaymentApi to all runtimes #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmpolaczyk merged 13 commits into from
Jun 24, 2024
Merged

Add XcmPaymentApi to all runtimes #592

tmpolaczyk merged 13 commits into from
Jun 24, 2024

Conversation

@tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Jun 14, 2024 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024 •
edited
Loading

Coverage Report

(master)

@@                    Coverage Diff                     @@
##           master   tomasz-xcm-payment-api      +/-   ##
==========================================================
+ Coverage   69.60%                   69.61%   +0.01%     
  Files         226                      226              
+ Lines       40210                    40378     +168     
==========================================================
+ Hits        27988                    28108     +120     
+ Misses      12222                    12270      +48
Files Changed Coverage
/container-chains/runtime-templates/frontier/src/lib.rs 58.88% (+0.12%) 🔼
/container-chains/runtime-templates/simple/src/lib.rs 72.54% (-1.17%) 🔽
/runtime/dancebox/src/lib.rs 89.11% (+0.18%) 🔼

Coverage generated Wed Jun 19 14:28:50 UTC 2024

girazoki
girazoki reviewed Jun 17, 2024
View reviewed changes
girazoki
girazoki reviewed Jun 17, 2024
View reviewed changes
@tmpolaczyk tmpolaczyk marked this pull request as ready for review June 18, 2024 16:08
@tmpolaczyk tmpolaczyk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jun 18, 2024
girazoki
girazoki reviewed Jun 19, 2024
View reviewed changes
girazoki
girazoki approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but looks good.

@tmpolaczyk tmpolaczyk merged commit 395df84 into master Jun 24, 2024
@tmpolaczyk tmpolaczyk deleted the tomasz-xcm-payment-api branch June 24, 2024 13:07
@akramhussein akramhussein mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girazoki girazoki girazoki approved these changes

Assignees

No one assigned

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmpolaczyk @girazoki