This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Switch to Castle dynamic proxy by default, simplify everything #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings back Castle.Core DynamicProxy for the proxy generation, which has been very robust over the years. All tests passing.
By leveraging Castle DP, we can speed up the beta release, since most of the new testing required would be exclusively on the new API and backwards compatibility, rather than having to keep investing in the non-trivial amount of work required to have a solid alternative approach (or two!). The alternative approaches are now in separate branches: - Build/design-time codegen using Roslyn: dev/codeanalysis branch - Static codegen using Cecil: dev/emit
stakx
reviewed
Aug 23, 2019
Contributor
stakx
left a comment
stakx
left a comment
There was a problem hiding this comment.
I took a quick look at this PR (nothing in-depth, I'm afraid). Nice to see DynamicProxy gets a comeback. :-) Just two minor comments.
Brought most of this from moq4, including the test suite :). Implemented the VerifyAll method for the legacy API since it was used by that test suite. Also added overloads for Verify with void methods which was also needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By leveraging Castle DP, we can speed up the beta release, since
most of the new testing required would be exclusively on the new
API and backwards compatibility, rather than having to keep
investing in the non-trivial amount of work required to have a
solid alternative approach (or two!).