Repository navigation
fix(clients): preserve portable MCP schemas in native workflows - #1580
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
N0zoM1z0
left a comment
There was a problem hiding this comment.
Maintainer self-review on bf9994a: portable ADB escapes preserve the prior admission grammar; the complete SDK-advertised pattern regression fails on baseline and passes fixed. All 31 focused ADB CLI/MCP and admission tests, static checks and docs checks pass. Native Linux Command Code, DeepSeek Harness, Qwen, Pi and Hermes normal/sticky-profile workflows pass with the complete 170-tool inventory through the production package; Command Code and DSH also pass source chat/call flows. Local model fixtures only; hosted authentication/live APIs and Windows clients remain unverified.
CI is still running; merge will be locked to this reviewed head after every required lane is green.
There was a problem hiding this comment.
Maintainer self-review on 6b64683: formatter-stable ADB patterns preserve admission and diagnostics. All 31 focused tests, 12 source/package native client flows with the full 170-tool inventory, static/docs checks and cleanup checks pass. All 27 final-head CI checks and nine workflows succeeded, with no unresolved review threads. Ready for SHA-locked merge. Live APIs and Windows clients remain unverified.
ADB input patterns with unescaped character-class hyphens fail Unicode-set schema validators, rejecting the entire MCP-enabled chat request before any tool executes. The formatter removes
\-escapes under the source regex'suflag. Use durable\x2descapes and the existing portable action identifier, share identical key constraints, and preserve the prior admission grammars and diagnostics. Closes #1581.REA already supports Command Code configuration, but lacked a native client workflow check. Add an optional verifier using official
command-code@1.79.2, its default deferred-schema interface, and a local OpenAI completions/SSE fixture, plus an ADB admission regression.The lane runs under a disposable OS account because auth, MCP tokens and sessions use the actual home. It guards setup targets, preserves an unrelated registration and backups, checks idempotence, and activates the complete REA skill through native default shared-skill discovery. Native discovery advertises all 170 REA tools; exact-name search returns all input schemas for dialect validation. When the client saves the large schema result, a native shell query returns its count and complete artifact digest. Actual JavaScript analysis of a Unicode-path fixture delivers approximately 29 KB of full named-schema Evidence to the next model request.
Validation:
npm run check:fastandnpm run docs:checkpass.The loopback BYOK model declares a million-token context with synthetic usage. A synthetic account-key value satisfies Command Code's print-mode gate, while native local-only mode refuses hosted API calls. Hosted authentication, live models, Windows clients, and real Android devices remain unverified. No real Hopper/Ghidra workflow was performed. Provider implementations are unchanged. The verifier creates no OS accounts and installs no clients.
Sanitized exported setting-key schema:
{"type":"string","minLength":1,"maxLength":256,"pattern":"^[A-Za-z0-9._\\x2d]+$"}