Skip to content

fix(clients): preserve portable MCP schemas in native workflows - #1580

Merged
N0zoM1z0 merged 8 commits into
mainfrom
test/commandcode-native-client-20261010
Oct 10, 2026
Merged

N0zoM1z0 merged 8 commits into
mainfrom
test/commandcode-native-client-20261010

Conversation

@N0zoM1z0

@N0zoM1z0 N0zoM1z0 commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

ADB input patterns with unescaped character-class hyphens fail Unicode-set schema validators, rejecting the entire MCP-enabled chat request before any tool executes. The formatter removes \- escapes under the source regex's u flag. Use durable \x2d escapes and the existing portable action identifier, share identical key constraints, and preserve the prior admission grammars and diagnostics. Closes #1581.

REA already supports Command Code configuration, but lacked a native client workflow check. Add an optional verifier using official command-code@1.79.2, its default deferred-schema interface, and a local OpenAI completions/SSE fixture, plus an ADB admission regression.

The lane runs under a disposable OS account because auth, MCP tokens and sessions use the actual home. It guards setup targets, preserves an unrelated registration and backups, checks idempotence, and activates the complete REA skill through native default shared-skill discovery. Native discovery advertises all 170 REA tools; exact-name search returns all input schemas for dialect validation. When the client saves the large schema result, a native shell query returns its count and complete artifact digest. Actual JavaScript analysis of a Unicode-path fixture delivers approximately 29 KB of full named-schema Evidence to the next model request.

Validation:

  • Source and production-only installed package: native Command Code ordinary chat and skill/search/analysis flows pass.
  • Native DeepSeek Harness 0.2.0-rc.2 ordinary chat and tool calls pass with complete exported-pattern checks. This fixture reproduced the pre-fix whole-request rejection; no live DeepSeek API claim.
  • Production-only Qwen 0.25.0, Pi 1.1.0, and pinned Hermes normal/sticky-profile workflows pass with the complete 170-tool inventory.
  • 31 focused ADB CLI/MCP, preserved-admission and full SDK-advertised pattern tests passed; the complete pattern regression failed on baseline. CLI option-alias regression, npm run check:fast and npm run docs:check pass.
  • Existing real pwntools environment: 149 public CLI/MCP and four bootstrap cases passed, with no target execution. The optional large-index lane was not requested.
  • Every completed native client run and the binary-layout run had verified empty descendant lists; a run-token scan found no remaining client/server processes.

The loopback BYOK model declares a million-token context with synthetic usage. A synthetic account-key value satisfies Command Code's print-mode gate, while native local-only mode refuses hosted API calls. Hosted authentication, live models, Windows clients, and real Android devices remain unverified. No real Hopper/Ghidra workflow was performed. Provider implementations are unchanged. The verifier creates no OS accounts and installs no clients.

Sanitized exported setting-key schema:

{"type":"string","minLength":1,"maxLength":256,"pattern":"^[A-Za-z0-9._\\x2d]+$"}

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@N0zoM1z0 N0zoM1z0 changed the title test(clients): verify native Command Code workflows fix(clients): preserve portable MCP schemas in native workflows Oct 10, 2026

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer self-review on bf9994a: portable ADB escapes preserve the prior admission grammar; the complete SDK-advertised pattern regression fails on baseline and passes fixed. All 31 focused ADB CLI/MCP and admission tests, static checks and docs checks pass. Native Linux Command Code, DeepSeek Harness, Qwen, Pi and Hermes normal/sticky-profile workflows pass with the complete 170-tool inventory through the production package; Command Code and DSH also pass source chat/call flows. Local model fixtures only; hosted authentication/live APIs and Windows clients remain unverified.

CI is still running; merge will be locked to this reviewed head after every required lane is green.

@N0zoM1z0 N0zoM1z0 changed the title fix(clients): preserve portable MCP schemas in native workflows test(clients): verify native Command Code and ADB schema compatibility Oct 10, 2026
@N0zoM1z0 N0zoM1z0 changed the title test(clients): verify native Command Code and ADB schema compatibility fix(clients): preserve portable MCP schemas in native workflows Oct 10, 2026

@N0zoM1z0 N0zoM1z0 left a comment •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer self-review on 6b64683: formatter-stable ADB patterns preserve admission and diagnostics. All 31 focused tests, 12 source/package native client flows with the full 170-tool inventory, static/docs checks and cleanup checks pass. All 27 final-head CI checks and nine workflows succeeded, with no unresolved review threads. Ready for SHA-locked merge. Live APIs and Windows clients remain unverified.

@N0zoM1z0
N0zoM1z0 merged commit 6d8f95e into main Oct 10, 2026
27 checks passed
@N0zoM1z0
N0zoM1z0 deleted the test/commandcode-native-client-20261010 branch October 10, 2026 16:09
@morluto morluto added bug Something isn't working area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ADB input patterns break Unicode-set MCP schema validation

2 participants